Question

0

Dropped Trigger?

Andrew Tamburino posted 1 Year Ago

Hi Everyone,

Our team was working, and we came across an error in our data and found that a trigger was dropped from our database. After review, we found the drop trigger was done in migration, but it doesn't look like this was documented anywhere. Was there a reason why this was left out? (Or did we miss this in docs)

Just wanted to flag this to everyone and potentially save someone else some time searching.

https://github.com/SparkDevNetwork/Rock/blob/aabc1bffe37a59680c60f95cd27ffb6141333155/Rock.Migrations/Migrations/Version%2014.0/Version%201.14.1/202211072054502_UpdateValueAsAttributeValueColumns.cs#L32

0
- Jon Edmiston replied 1 Year Ago
We typically don't document technical changes in the foundation of the software. They should be transparent to organizations. Do you have more information on how this effected you? Perhaps there's something we can improve on.
Edit Answer

We typically don't document technical changes in the foundation of the software. They should be transparent to organizations. Do you have more information on how this effected you? Perhaps there's something we can improve on.
We typically don't document technical changes in the foundation of the software. They should be transparent to organizations. Do you have more information on how this effected you? Perhaps there's something we can improve on.
We typically don't document technical changes in the foundation of the software. They should be transparent to organizations. Do you have more information on how this effected you? Perhaps there's something we can improve on.
Save Cancel
0
- Andrew Tamburino replied 1 Year Ago
Hi Jon,

Thanks for getting back to me so quickly! We have a couple of SQL jobs that do large bulk updates to that table, we updated into the value column and relied on the trigger to update valueasdate.

After we upgraded to 14.1, we found that a data point didn't update when we were reviewing a report export and caught it that way. I hope this helps!
Edit Answer

Hi Jon,  Thanks for getting back to me so quickly! We have a couple of SQL jobs that do large bulk updates to that table, we updated into the value column and relied on the trigger to update valueasdate.  After we upgraded to 14.1, we found that a data point didn't update when we were reviewing a report export and caught it that way. I hope this helps! 
Hi Jon,  Thanks for getting back to me so quickly! We have a couple of SQL jobs that do large bulk updates to that table, we updated into the value column and relied on the trigger to update valueasdate.  After we upgraded to 14.1, we found that a data point didn't update when we were reviewing a report export and caught it that way. I hope this helps! 
Hi Jon,  Thanks for getting back to me so quickly! We have a couple of SQL jobs that do large bulk updates to that table, we updated into the value column and relied on the trigger to update valueasdate.  After we upgraded to 14.1, we found that a data point didn't update when we were reviewing a report export and caught it that way. I hope this helps! 
Save Cancel